Skip to content

Installation fails when directory contains a space#311

Merged
rakuri255 merged 1 commit intomainfrom
Installation-fails-when-directory-contains-a-space-#250-
Mar 4, 2026
Merged

Installation fails when directory contains a space#311
rakuri255 merged 1 commit intomainfrom
Installation-fails-when-directory-contains-a-space-#250-

Conversation

@rakuri255
Copy link
Copy Markdown
Owner

@rakuri255 rakuri255 commented Mar 4, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

Release Notes

Bug Fixes

  • Improved handling of Python executable paths containing spaces during installation on Windows.
  • Enhanced error handling in installation scripts to properly terminate on dependency synchronization failures instead of continuing with incomplete setup.

@rakuri255 rakuri255 linked an issue Mar 4, 2026 that may be closed by this pull request
Installation fails when directory contains a space #250
Closed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 4, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fbd61070-2cd0-4a51-8e49-d31e4401b602

📥 Commits

Reviewing files that changed from the base of the PR and between d828a0f and 2cfe539.

📒 Files selected for processing (2)
  • install/CPU/windows_cpu.bat
  • install/CUDA/windows_cuda_gpu.bat
📝 Walkthrough

Walkthrough

Two Windows batch installation scripts for CPU and CUDA environments were updated to quote Python executable paths in version checks and dependency synchronization commands. The CPU variant also added explicit error handling for synchronization failures.

Changes

Cohort / File(s) Summary
Windows Installation Scripts
install/CPU/windows_cpu.bat, install/CUDA/windows_cuda_gpu.bat		 Added quotes around !PYTHON_EXE! variable in version display and uv sync commands to properly handle Python paths containing spaces. CPU script also added explicit exit /b 1 on uv sync failure for improved error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Poem

🐰 A rabbit hops through Windows paths,
Where spaces once caused scripting wrath,
With quotes now safe around the way,
Python runs without delay! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Installation-fails-when-directory-contains-a-space-#250-

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rakuri255 rakuri255 merged commit 705909d into main Mar 4, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installation fails when directory contains a space

1 participant

@rakuri255